From 8d16a5693c3a06cdebfd582ada3e2592f3ca863a Mon Sep 17 00:00:00 2001 From: Nick Craig-Wood Date: Sat, 12 Jan 2019 17:09:11 +0000 Subject: [PATCH] vendor: update github.com/goftp/server - fixes #2845 --- go.mod | 2 +- go.sum | 2 ++ vendor/github.com/goftp/server/socket.go | 15 +++++++++++++-- vendor/modules.txt | 2 +- 4 files changed, 17 insertions(+), 4 deletions(-) diff --git a/go.mod b/go.mod index e857c22ec..060d69da4 100644 --- a/go.mod +++ b/go.mod @@ -18,7 +18,7 @@ require ( github.com/djherbis/times v1.1.0 github.com/dropbox/dropbox-sdk-go-unofficial v5.4.0+incompatible github.com/goftp/file-driver v0.0.0-20180502053751-5d604a0fc0c9 // indirect - github.com/goftp/server v0.0.0-20180914132916-1fd52c8552f1 + github.com/goftp/server v0.0.0-20190111142836-88de73f463af github.com/google/go-querystring v1.0.0 // indirect github.com/gopherjs/gopherjs v0.0.0-20181103185306-d547d1d9531e // indirect github.com/inconshreveable/mousetrap v1.0.0 // indirect diff --git a/go.sum b/go.sum index cf55806c2..fa933ca1d 100644 --- a/go.sum +++ b/go.sum @@ -39,6 +39,8 @@ github.com/goftp/file-driver v0.0.0-20180502053751-5d604a0fc0c9 h1:cC0Hbb+18DJ4i github.com/goftp/file-driver v0.0.0-20180502053751-5d604a0fc0c9/go.mod h1:GpOj6zuVBG3Inr9qjEnuVTgBlk2lZ1S9DcoFiXWyKss= github.com/goftp/server v0.0.0-20180914132916-1fd52c8552f1 h1:WjgeEHEDLGx56ndxS6FYi6qFjZGajSVHPuEPdpJ60cI= github.com/goftp/server v0.0.0-20180914132916-1fd52c8552f1/go.mod h1:k/SS6VWkxY7dHPhoMQ8IdRu8L4lQtmGbhyXGg+vCnXE= +github.com/goftp/server v0.0.0-20190111142836-88de73f463af h1:PJxb1aA1z+Ohy2j28L92+ng9phXpZVFRFbPkfmJcRGo= +github.com/goftp/server v0.0.0-20190111142836-88de73f463af/go.mod h1:k/SS6VWkxY7dHPhoMQ8IdRu8L4lQtmGbhyXGg+vCnXE= github.com/golang/protobuf v1.2.0 h1:P3YflyNX/ehuJFLhxviNdFxQPkGK5cDcApsge1SqnvM= github.com/golang/protobuf v1.2.0/go.mod h1:6lQm79b+lXiMfvg/cZm0SGofjICqVBUtrP5yJMmIC1U= github.com/google/go-querystring v1.0.0 h1:Xkwi/a1rcvNg1PPYe5vI8GbeBY/jrVuDX5ASuANWTrk= diff --git a/vendor/github.com/goftp/server/socket.go b/vendor/github.com/goftp/server/socket.go index 3795e27ce..945c9d8c6 100644 --- a/vendor/github.com/goftp/server/socket.go +++ b/vendor/github.com/goftp/server/socket.go @@ -14,6 +14,7 @@ import ( "strings" "sync" "syscall" + "time" ) // DataSocket describes a data socket is used to send non-control data between the client and @@ -208,13 +209,23 @@ func (socket *ftpPassiveSocket) GoListenAndServe(sessionID string) (err error) { return } - var listener net.Listener - listener, err = net.ListenTCP("tcp", laddr) + var tcplistener *net.TCPListener + tcplistener, err = net.ListenTCP("tcp", laddr) if err != nil { socket.logger.Print(sessionID, err) return } + // The timeout, for a remote client to establish connection + // with a PASV style data connection. + const acceptTimeout = 60 * time.Second + err = tcplistener.SetDeadline(time.Now().Add(acceptTimeout)) + if err != nil { + socket.logger.Print(sessionID, err) + return + } + + var listener net.Listener = tcplistener add := listener.Addr() parts := strings.Split(add.String(), ":") port, err := strconv.Atoi(parts[len(parts)-1]) diff --git a/vendor/modules.txt b/vendor/modules.txt index f5d21fa17..d45c26255 100644 --- a/vendor/modules.txt +++ b/vendor/modules.txt @@ -83,7 +83,7 @@ github.com/dropbox/dropbox-sdk-go-unofficial/dropbox/seen_state github.com/dropbox/dropbox-sdk-go-unofficial/dropbox/team_common github.com/dropbox/dropbox-sdk-go-unofficial/dropbox/team_policies github.com/dropbox/dropbox-sdk-go-unofficial/dropbox/users_common -# github.com/goftp/server v0.0.0-20180914132916-1fd52c8552f1 +# github.com/goftp/server v0.0.0-20190111142836-88de73f463af github.com/goftp/server # github.com/golang/protobuf v1.2.0 github.com/golang/protobuf/proto