yves
/
rclone
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

fs/accounting: Added StatsInfo locking in statsGroups sum function (#3844) 

Without the fix we can have a race, example:

```
Write at 0x00c000432039 by goroutine 187:
  github.com/rclone/rclone/fs/accounting.(*StatsInfo).Error()
      fs/accounting/stats.go:495 +0x3f1
  github.com/rclone/rclone/fs/accounting.(*StatsInfo).Error-fm()
      fs/accounting/stats.go:477 +0x55
  github.com/rclone/rclone/fs/walk.listRwalk.func1()
      fs/walk/walk.go:162 +0xd2
  github.com/rclone/rclone/fs/walk.walk.func2()
      fs/walk/walk.go:402 +0x30f

Previous read at 0x00c000432039 by goroutine 184:
  github.com/rclone/rclone/fs/accounting.(*statsGroups).sum()
      fs/accounting/stats_groups.go:351 +0xcae
  github.com/rclone/rclone/fs/accounting.rcTransferredStats()
      fs/accounting/stats_groups.go:132 +0x1f4
```

Fixes #3844
s3-about
Michał Matczuk 2020-01-03 14:55:30 +01:00 committed by Nick Craig-Wood
parent 7e6fac8b1e
commit eb10ac346f
1 changed files with 18 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
fs/accounting/stats_groups.go
View File

@ -344,8 +344,11 @@ func (sg *statsGroups) names() []string {
func (sg *statsGroups) sum() *StatsInfo {
sg.mu.Lock()
defer sg.mu.Unlock()
sum := NewStats()
for _, stats := range sg.m {
stats.mu.RLock()
{
sum.bytes += stats.bytes
sum.errors += stats.errors
sum.fatalError = sum.fatalError || stats.fatalError
@ -361,6 +364,8 @@ func (sg *statsGroups) sum() *StatsInfo {
}
sum.startedTransfers = append(sum.startedTransfers, stats.startedTransfers...)
}
stats.mu.RUnlock()
}
return sum
}